Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Feature to modify the comment form title #57541

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Add: Feature to modify the comment form title #57541

wants to merge 2 commits into from

Conversation

SH4LIN
Copy link
Contributor

@SH4LIN SH4LIN commented Jan 4, 2024 •
edited by mikachan
Loading

What?

  • This PR will add support for the comment form title to be editable.

Why?

  • This is an enhancement PR which will allow to change the comment form title.

How?

  • This PR adds block attribute and RichText component from the static H3 tag.

Testing Instructions

  1. Open editor.
  2. Insert the comment form block
  3. Add the title in a place where it says Leave a reply.
  4. Publish the post
  5. And preview it on frontend title will reflect on frontend.

Testing Instructions for Keyboard

Screenshots or screencast

Screen.Recording.2024-01-04.at.4.55.38.PM.mov

Covers

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @SH4LIN! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Block] Post Comments Form Affects the Comments Form Block label Apr 25, 2024
@mikachan mikachan added the [Type] Enhancement A suggestion for improvement. label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Block] Post Comments Form Affects the Comments Form Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Option to Edit Comments Title & Comments Form Title
3 participants
@SH4LIN @skorasaurus @mikachan