Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reset button on ColorGradientSettingsDropdown doesn't close the popover #68469

Closed
3 of 6 tasks
shimotmk opened this issue Jan 2, 2025 · 3 comments
Closed
3 of 6 tasks
Labels
[Feature] Colors Color management [Type] Bug An existing feature does not function as intended

Comments

@shimotmk
Copy link
Contributor

shimotmk commented Jan 2, 2025

Description

When you use the reset button on ColorGradientSettingsDropdown, the popover doesn't close and the popovers may overlap.

Step-by-step reproduction instructions

  1. Go to Block editor
  2. Set Background color or Text color
  3. Reset the Color from the ColorGradientSettingsDropdown.

Screenshots, screen recording, code snippet

gutenberg-color.mp4

Environment info

  • WordPress Version 6.7.1
  • Gutenberg Version 19.9.0
  • Twenty Twenty-Five 1.0

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@shimotmk shimotmk added the [Type] Bug An existing feature does not function as intended label Jan 2, 2025
@Rishit30G
Copy link
Contributor

Rishit30G commented Jan 3, 2025

Thanks for sharing the issue
I tried replicating the issue, but for me the popover is closing as I reset the background/text colour
Sharing the screencast for the same:

Screen.Recording.2025-01-03.at.8.47.41.AM.mov

Enviornment:

  • WordPress Version 6.7.1
  • Gutenberg Version 19.9.0
  • Twenty Twenty-Five 1.0

@himanshupathak95
Copy link
Contributor

Hey @shimotmk, I tested both 6.7.1 and trunk, and it seems to be working fine for me -

Screen.Recording.2025-01-03.at.08.54.03.mov

Are there any additional plugins interfering with the popover?

@t-hamano t-hamano added the [Feature] Colors Color management label Jan 3, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Jan 3, 2025

Thanks for the report.

The upcoming release of Gutenberg 20.0 should resolve this issue. This issue has been resolved in #67800. Here is the code.

@t-hamano t-hamano closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants