From b0bf1008fc1c52184a7836c029c50250a9f6c3f7 Mon Sep 17 00:00:00 2001 From: Jorge Costa Date: Mon, 8 Jul 2024 16:54:26 +0100 Subject: [PATCH] Update test cases --- .../site-editor/dataviews-list-layout-keyboard.spec.js | 9 +++++++++ test/e2e/specs/site-editor/new-templates-list.spec.js | 3 +-- test/performance/specs/site-editor.spec.js | 8 ++------ 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js b/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js index 3d98358a7aeb7..f6b01db63d911 100644 --- a/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js +++ b/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js @@ -46,6 +46,11 @@ test.describe( 'Dataviews List Layout', () => { page.getByRole( 'button', { name: 'Reset' } ) ).toBeFocused(); + await page.keyboard.press( 'Tab' ); + await expect( + page.getByRole( 'button', { name: 'Layout' } ) + ).toBeFocused(); + await page.keyboard.press( 'Tab' ); await expect( page.getByRole( 'button', { name: 'View options' } ) @@ -69,6 +74,7 @@ test.describe( 'Dataviews List Layout', () => { await page.keyboard.press( 'Tab' ); await page.keyboard.press( 'Tab' ); await page.keyboard.press( 'Tab' ); + await page.keyboard.press( 'Tab' ); // Make sure the items have loaded before reaching for the 1st item in the list. await expect( page.getByRole( 'grid' ) ).toBeVisible(); @@ -98,6 +104,7 @@ test.describe( 'Dataviews List Layout', () => { await page.keyboard.press( 'Tab' ); await page.keyboard.press( 'Tab' ); await page.keyboard.press( 'Tab' ); + await page.keyboard.press( 'Tab' ); // Make sure the items have loaded before reaching for the 1st item in the list. await expect( page.getByRole( 'grid' ) ).toBeVisible(); @@ -121,6 +128,7 @@ test.describe( 'Dataviews List Layout', () => { await page.keyboard.press( 'Tab' ); await page.keyboard.press( 'Tab' ); await page.keyboard.press( 'Tab' ); + await page.keyboard.press( 'Tab' ); // Make sure the items have loaded before reaching for the 1st item in the list. await expect( page.getByRole( 'grid' ) ).toBeVisible(); @@ -162,6 +170,7 @@ test.describe( 'Dataviews List Layout', () => { await page.keyboard.press( 'Tab' ); await page.keyboard.press( 'Tab' ); await page.keyboard.press( 'Tab' ); + await page.keyboard.press( 'Tab' ); // Make sure the items have loaded before reaching for the 1st item in the list. await expect( page.getByRole( 'grid' ) ).toBeVisible(); diff --git a/test/e2e/specs/site-editor/new-templates-list.spec.js b/test/e2e/specs/site-editor/new-templates-list.spec.js index ab37244df107c..7273e3169db34 100644 --- a/test/e2e/specs/site-editor/new-templates-list.spec.js +++ b/test/e2e/specs/site-editor/new-templates-list.spec.js @@ -86,8 +86,7 @@ test.describe( 'Templates', () => { test( 'Field visibility', async ( { admin, page } ) => { await admin.visitSiteEditor( { postType: 'wp_template' } ); - await page.getByRole( 'button', { name: 'View options' } ).click(); - await page.getByRole( 'menuitem', { name: 'Layout' } ).click(); + await page.getByRole( 'button', { name: 'Layout' } ).click(); await page.getByRole( 'menuitemradio', { name: 'Table' } ).click(); await page.getByRole( 'button', { name: 'Description' } ).click(); diff --git a/test/performance/specs/site-editor.spec.js b/test/performance/specs/site-editor.spec.js index 58f2cf5cd4b4e..520ad76de22ee 100644 --- a/test/performance/specs/site-editor.spec.js +++ b/test/performance/specs/site-editor.spec.js @@ -222,15 +222,11 @@ test.describe( 'Site Editor Performance', () => { // If it's there, switch to the list layout before running the test. // See https://github.com/WordPress/gutenberg/pull/59792 const isDataViewsUI = await page - .getByRole( 'button', { name: 'View options' } ) + .getByRole( 'button', { name: 'Layout' } ) .isVisible(); if ( isDataViewsUI ) { await page - .getByRole( 'button', { name: 'View options' } ) - .click(); - await page - .getByRole( 'menuitem' ) - .filter( { has: page.getByText( 'Layout' ) } ) + .getByRole( 'button', { name: 'Layout' } ) .click(); await page .getByRole( 'menuitemradio' )