PreparedSQLSniff: Trigger on variables in sql in heredocs and ignore nowdoc syntax #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
changed the title
…nowdoc syntax Includes unit tests. Also: * Adds unit tests for multi-line `T_DOUBLE_QUOTED_STRING` and `T_CONSTANT_ENCAPSED_STRING` which were missing
jrfnl
force-pushed
the
feature/review-text-string-tokens-prepared-sql
branch
from
a82bec9 to
ee038fe
Compare
JDGrimes
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes unit tests.
Also:
T_DOUBLE_QUOTED_STRINGandT_CONSTANT_ENCAPSED_STRINGwhich were missingRelated to #764