Fix some undefined index notices in the WordPress.XSS.EscapeOutput sniff.
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sniff. These would be thrown when live coding/running the sniffs on code with parse errors.
JDGrimes
suggested changes
Jan 5, 2017
| @@ -208,6 +208,11 @@ public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) { | |||
|
|
|||
| if ( T_OPEN_PARENTHESIS === $this->tokens[ $i ]['code'] ) { | |||
|
|
|||
| if ( ! isset( $this->tokens[ $i ]['parenthesis_closer'] ) ) { | |||
| // Live coding or parse error. | |||
| break; | |||
There was a problem hiding this comment.
Usually when PHPCS's core sniffs detect a parse error, they don't just skip out, they add a warning. At least they do in some cases. Should we consider doing the same here?
There was a problem hiding this comment.
IMHO that's what the Generic.PHP.Syntax sniff is for (included in extra)
There was a problem hiding this comment.
Yep, that makes sense. So I guess for consistency we should change the one place we give an error for syntax issues. But that can be a separate PR, I guess.
| $i = $this->tokens[ $function_opener ]['parenthesis_closer']; | ||
| } else { | ||
| // Live coding or parse error. | ||
| break; |
JDGrimes
approved these changes
Jan 5, 2017
JDGrimes
added a commit
that referenced
this pull request
Jan 5, 2017
grappler
approved these changes
Jan 5, 2017
JDGrimes
added a commit
that referenced
this pull request
Jan 5, 2017
GaryJones
pushed a commit
that referenced
this pull request
Jan 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These would be thrown when live coding/running the sniffs on code with parse errors.
Quick fix for #248 (comment)
/cc @grappler