Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress.com VIP Go ruleset #951

Closed
johnbillion opened this issue May 27, 2017 · 4 comments
Closed

WordPress.com VIP Go ruleset #951

johnbillion opened this issue May 27, 2017 · 4 comments

Comments

@johnbillion
Copy link
Member

johnbillion commented May 27, 2017

The existing WordPress-VIP ruleset is not technically specific to the WordPress.com VIP environment, although its sniffs are based on its requirements. Lots of people use the ruleset for projects not hosted on WordPress.com VIP in order to adhere to the most stringent practices.

The new WordPress.com VIP Go environment (which is containerised) has much fewer restrictions, and therefore many of the WordPress.com VIP-specific sniffs are not relevant. As one example, you are allowed to use switch_to_blog() on a WordPress.com VIP Go environment.

Should a WordPress.com VIP Go specific ruleset be introduced? Is this something that belongs as part of WPCS or is this really a responsibility of Automattic? Discuss!

CCing people who've expressed interest in this: @jazzsequence @simonwheatley

@johnbillion
Copy link
Member Author

@GaryJones
Copy link
Member

Is this something that belongs as part of WPCS or is this really a responsibility of Automattic?

We've had discussions elsewhere (reference needed) about whether WordPress-VIP should still be part of this repo or not. So in terms of a variant for WordPress VIP Go, I'd strongly suggest it should be handled by Automattic.

@grappler
Copy link
Member

This was discussed previously here: #676

As Automattic has created their own repo we could work on a migration plan where VIP specific check are moved to their repo.

This would make it easier for them to maintain their own sniffs like: #945

CC/ @imsimond

@jrfnl
Copy link
Member

jrfnl commented Mar 1, 2018

Closing as superseded by #1309

@jrfnl jrfnl closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants