Skip to content

Commit

Permalink
Merge pull request #33 from WordPress-Phoenix/feature/Textarea_fix
Browse files Browse the repository at this point in the history
Fixing Textarea value display issue
  • Loading branch information
scarstens authored Feb 8, 2019
2 parents 9f0b735 + fdf0df7 commit 12e1625
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- run:
name: Install Testing Dependencies
command: |
composer require --dev --no-update "wp-coding-standards/wpcs" ; \
composer require --dev --no-update "wp-coding-standards/wpcs:^0.14.1" ; \
composer install --dev --no-autoloader ; \
sudo ./vendor/bin/phpcs --config-set installed_paths $PWD/vendor/wp-coding-standards/wpcs ;
- run: sudo ./vendor/bin/phpcs --config-set installed_paths $PWD/vendor/wp-coding-standards/wpcs
Expand Down
4 changes: 2 additions & 2 deletions inc/class-page.php
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function page_header() {
<?php
endif;
echo esc_attr( $this->page_title );
?>
?>
</h1>
<input type="submit" class="button button-primary button-hero save-all" value="Save All" name="submit"/>
</div>
Expand Down Expand Up @@ -164,7 +164,7 @@ public function page_content_sidebar() {
<?php
endif;
echo esc_html( $section['label'] );
?>
?>
<?php if ( count( $section['parts'] ) > 1 ) : ?>
<small class="part-count">
<?php echo esc_attr( count( $section['parts'] ) ); ?>
Expand Down
12 changes: 6 additions & 6 deletions inc/parts/class-textarea.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ class Textarea extends Part {
public function render() {
$this->cols = ! empty( $this->cols ) ? $this->cols : 80;
$this->rows = ! empty( $this->rows ) ? $this->rows : 10;
// @codingStandardsIgnoreStart
?><textarea title="<?php echo esc_attr( $this->id ); ?>"
id="<?php echo esc_attr( $this->id ); ?>" name="<?php echo esc_attr( $this->id ); ?>"
cols="<?php echo esc_attr( $this->cols ); ?>" rows="<?php echo esc_attr( $this->rows ); ?>">
<?php
echo esc_html( $this->saved );
?>
</textarea>
id="<?php echo esc_attr( $this->id ); ?>" name="<?php echo esc_attr( $this->id ); ?>"
cols="<?php echo esc_attr( $this->cols ); ?>" rows="<?php echo esc_attr( $this->rows ); ?>"><?php
echo esc_html( $this->get_saved() );
?></textarea>
<?php
// @codingStandardsIgnoreEnd
}

}
2 changes: 1 addition & 1 deletion wpop-init.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*
* @authors 🌵 WordPress Phoenix 🌵 / Seth Carstens, David Ryan
* @package wpop
* @version 4.1.8
* @version 4.1.9
* @license GPL-2.0+ - please retain comments that express original build of this file by the author.
*/

Expand Down

0 comments on commit 12e1625

Please sign in to comment.