-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some issues with examples #2
Comments
@jonchengkuo , thank you for useful project review. I'll correct documentation asap and also i'll make example project without WebApiToolkit and with it. And also i will clarify order of base classes template paramters. Thank you. |
@jonchengkuo , I've prepared a full example how to use (whole solution) you could check it here: https://github.com/Wissance/WeatherControl |
Readme updated using examples from link above |
Hi Ushakov,
I like your WebApiToolkit. I found a few minor issues on the project home page (https://github.com/Wissance/WebApiToolkit):
I also have the following comments on WebApiToolkit:
Base Controller: I personally think that passing the Manager object into the base controller via a constructor is easier to understand.
i.e., public GroupController(GroupManager manager) : base(manager) { }
Order of type parameters is inconsistent between base controller and base manager.
BasicReadController<GroupDto, GroupEntity, int>
ModelManager<GroupEntity, GroupDto, int>
Joncheng
The text was updated successfully, but these errors were encountered: