Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding multiple timers to a single target causes problems #85

Open
w00tyd00d opened this issue Mar 30, 2024 · 0 comments
Open

Adding multiple timers to a single target causes problems #85

w00tyd00d opened this issue Mar 30, 2024 · 0 comments
Assignees
Labels
Priority: Low This can be looked into after a week Status: Pending Looking into it Type: Bug Something isn't working

Comments

@w00tyd00d
Copy link

Describe the bug

The Timer.add() allows the user to add multiple timers to a single entity, which causes buggy and unintended behavior.

image

In __load__.mcfunction:

image

In __private__/timer_add/main.mcfunction:

image

To Reproduce

  1. Use Timer.add() to add a timer to the same target twice

Expected behavior

Should probably throw an exception, telling the user the timer already existed prior and should use Timer.set() instead.

Desktop

  • Windows 10

Additional context

Timer.add() also adds an additional scoreboard to the datapack, even when the scoreboard has already been created. This only occurs in the first instance of using the scoreboard within a Timer.add() call, so it seems Timer properly caches previously scoreboard its created but doesn't recognize scoreboards created by other means.

@w00tyd00d w00tyd00d added the Type: Bug Something isn't working label Mar 30, 2024
@WingedSeal WingedSeal added Status: Pending Looking into it Priority: Low This can be looked into after a week labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low This can be looked into after a week Status: Pending Looking into it Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants