Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close-button-type-change]- close button type should be of type "button" #1036

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

vippatel90
Copy link
Contributor

Default type 'submit' causes form to trigger submit action when placed inside FORM tag.
This can happen when FORM tag is in parent for long forms and child components wants to show dismissible alert.

…ton'. Default type 'submit' causes form to trigger submit action if put inside FORM tag
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 1020b3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@westpac/ui Patch
protoform Patch
site Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-protoform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:32am
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:32am
gel-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:32am

Copy link

vercel bot commented Feb 19, 2025

@vippatel90 is attempting to deploy a commit to the WestpacGEL Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants