Oct 2023 update #43
Merged
Oct 2023 update #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 2 2
Lines 226 226
=======================================
Hits 216 216
Misses 10 10
☔ View full report in Codecov by Sentry. |
docs/tutorial.rst
Outdated
| @@ -10,8 +12,16 @@ This tutorial will walk you through using ELECTRIC to analyze the electric field | |||
| - You are able to download or clone a directory from git. | |||
| - You are familiar with bash scripts. | |||
|
|
|||
| To begin thee tutorial, first make sure you have your `electric` environment activated: | |||
There was a problem hiding this comment.
Thanks for the update. Other than the small typo, it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes updates to ELECTRIC:
iteritemsis changed toitemsin ELECTRIC.iteritemshas been deprecated and the replacement isitems. Its presence in ELECTRIC is making the script incompatible with newer pandas versions.environment.yamlcontainingcmake,gfortranand Python packages is added and instructions for use are added to the docs.