-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Error System #52
Labels
🐛 Bug
Something isn't working
🧹 Housekeeping
Improvements to code quality
UI
User Interface
UX
User Experience
Milestone
Comments
WYVERN2742
added a commit
that referenced
this issue
May 20, 2024
- Add support for focal spot in beam parameters - Change typing of PipeConnection to Connection - This fixes a compilation issue on Linux - Replace gvxr.computeProjectionSet() with a loop - This is due to a breaking change with latest master of gvxr - Add tqdm progress bar to reconstruction - This may be temporary, should be investigated with Better Error System #52
WYVERN2742
added a commit
that referenced
this issue
May 20, 2024
feat: ✨ Add support for focal spot size - Add support for focal spot in beam parameters - Change typing of PipeConnection to Connection - This fixes a compilation issue on Linux - Replace gvxr.computeProjectionSet() with a loop - This is due to a breaking change with latest master of gvxr - Add tqdm progress bar to reconstruction - This may be temporary, should be investigated with Better Error System #52
"PUT /material/set HTTP/1.1" 200 Has no failure case, issues saving new materials are not propagated to frontend |
WYVERN2742
added a commit
that referenced
this issue
Aug 17, 2024
This works towards #52 - Standardized logging format for all submodules - All endpoints, session manager, simulator monitoring - Save GVXR logs to seperate file - Redone logging for all modules - Added quick validation for adding samples - Kill simulator child when strange behavior is detected. - This is currently causing issues into restoring into a good state. More work is required for #81
WYVERN2742
added a commit
that referenced
this issue
Aug 17, 2024
This works towards #52 - Standardized logging format for all submodules - All endpoints, session manager, simulator monitoring - Save GVXR logs to seperate file - Redone logging for all modules - Added quick validation for adding samples - Kill simulator child when strange behavior is detected. - This is currently causing issues into restoring into a good state. More work is required for #81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐛 Bug
Something isn't working
🧹 Housekeeping
Improvements to code quality
UI
User Interface
UX
User Experience
Right now, the error system is a mess and does not cover all scenarios.
The error system should be redone alongside the validation system in order to clearly indicate to the user what has gone wrong. Validation should preemptively prevent any user-side inputs that will cause errors to the backend.
Some examples:
The text was updated successfully, but these errors were encountered: