Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate dark theme color settings #12613

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Sep 27, 2024

  1. Add separte dark theme color settings

    - Modifed the form to have two color fields (one for dark and one for light theme).
    - The colors are stored  in this form"#ffffff,#000000". Where the first one is for light theme and the other for dark theme.
    - Then the custom.css consumes the values and performs a split(defined in custom_filters.py) on the color string to get the two colors.
    - Those colors then are defined in css variables and consumed by the elements that need them.
    - The css variables change base on the current theme (for dark values to be applied it is expected that the body tag has `data-theme="dark"`)
    meel-hd committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    129e2f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Add data-theme for body tag

    meel-hd committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    2cb70d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Fix dark theme color fields

    - Insure backward compatibility with previous theme color settings.
    
    - In the new implementation it considers if there was previous color settings. If so it applies them to dark theme colors too.
    meel-hd committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    37222f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c696ec View commit details
    Browse the repository at this point in the history