-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): add two-factor authentication #12173
Conversation
0e825c6
to
349e05a
Compare
b7e3472
to
0cd82d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
d49a42f
to
24a95e5
Compare
Hi, creator of django-otp-webauthn here 👋 Very cool to see my package being put to good use. It's pretty new, and has yet to prove itself in the context of a production site. Please keep me updated on any issues encountered 👍 |
I was originally thinking about two_factor, but it turned out to be too opinionated for our use-case, so I ended up trying django-otp-webauthn. |
a40fce4
to
171a6e0
Compare
c5c5e16
to
cd790ac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12173 +/- ##
==========================================
+ Coverage 90.82% 91.12% +0.30%
==========================================
Files 554 586 +32
Lines 57306 60072 +2766
Branches 9122 9502 +380
==========================================
+ Hits 52046 54743 +2697
- Misses 3640 3696 +56
- Partials 1620 1633 +13
|
36288ae
to
ee4e088
Compare
f6bdf70
to
421e1f2
Compare
- Implemented using django-otp and django-otp-webauthn - Support for TOTP, WebAuthn and recovery codes Fixes WeblateOrg#1681
"authenticator apps" is universally used term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go like this
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Proposed changes
Fixes #1681
Checklist
Pending tasks:
Other information