-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11923 cyrtranslit suggestion service #12154
11923 cyrtranslit suggestion service #12154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also add documentation?
./manage.py list_machinery
will output template to updatedocs/admin/machine.rst
- Add changelog entry referencing the new engine
We probably should then revisit #2136 as it would be useful to translate from another translation here instead of the source language (which is likely to be English).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12154 +/- ##
==========================================
+ Coverage 90.82% 91.15% +0.33%
==========================================
Files 554 584 +30
Lines 57306 59595 +2289
Branches 9122 9452 +330
==========================================
+ Hits 52046 54325 +2279
- Misses 3640 3652 +12
+ Partials 1620 1618 -2
|
I've added changelog entry in 3d28298 and I think this is ready to merge. |
@nijel thanks for your help on the documentation, I was still facing some issue trying to get the sphinx to build properly locally |
Proposed changes
New machine translation class
CyrTranslitTranslation
is used as interface to the cytranslit moduleChecklist
Other information
fixes #11923