Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11923 cyrtranslit suggestion service #12154

Merged
merged 11 commits into from
Aug 5, 2024

Conversation

gersona
Copy link
Collaborator

@gersona gersona commented Jul 29, 2024

Proposed changes

New machine translation class CyrTranslitTranslation is used as interface to the cytranslit module

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

fixes #11923

Copy link
Member

@nijel nijel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add documentation?

  • ./manage.py list_machinery will output template to update docs/admin/machine.rst
  • Add changelog entry referencing the new engine

We probably should then revisit #2136 as it would be useful to translate from another translation here instead of the source language (which is likely to be English).

pyproject.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (6aee586) to head (3d28298).
Report is 2995 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12154      +/-   ##
==========================================
+ Coverage   90.82%   91.15%   +0.33%     
==========================================
  Files         554      584      +30     
  Lines       57306    59595    +2289     
  Branches     9122     9452     +330     
==========================================
+ Hits        52046    54325    +2279     
- Misses       3640     3652      +12     
+ Partials     1620     1618       -2     
Files Coverage Δ
weblate/checks/tests/test_checks.py 97.74% <100.00%> (+1.07%) ⬆️
weblate/machinery/cyrtranslit.py 100.00% <100.00%> (ø)
weblate/machinery/models.py 100.00% <ø> (ø)
weblate/machinery/tests.py 99.60% <100.00%> (-0.25%) ⬇️
weblate/utils/requirements.py 73.86% <ø> (ø)

... and 397 files with indirect coverage changes

docs/admin/machine.rst Outdated Show resolved Hide resolved
@nijel nijel added this to the 5.7 milestone Aug 5, 2024
@nijel nijel self-assigned this Aug 5, 2024
@nijel
Copy link
Member

nijel commented Aug 5, 2024

I've added changelog entry in 3d28298 and I think this is ready to merge.

@nijel nijel enabled auto-merge (squash) August 5, 2024 12:53
@gersona
Copy link
Collaborator Author

gersona commented Aug 5, 2024

@nijel thanks for your help on the documentation, I was still facing some issue trying to get the sphinx to build properly locally

@nijel nijel merged commit 7722ae6 into WeblateOrg:main Aug 5, 2024
31 checks passed
@gersona gersona deleted the 11923_cyrtranslit_suggestion_service branch September 19, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automatic suggestion service for transliteration of Cyrillic script to Latin
2 participants