-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be more indulgent with "Automatic Suggestions" URLs #12291
Comments
What Weblate version do you use? The custom URL validator is used since Weblate 5.5 (see ec0af64). |
…ah, but it seems to add this validator on top of the existing one instead of replacing it. |
The previous solution applied both Django and Weblate validation to these fields. Fixes WeblateOrg#12291
I recently update to docker image weblate/weblate:5.7.0.0. Thanks for checking this :) |
Thank you for your report; the issue you have reported has just been fixed.
|
1 similar comment
Thank you for your report; the issue you have reported has just been fixed.
|
Describe the problem
As you might know, in dockerized environments, containers can communicate between them using Docker's container name.
The problem is that, currently my container's name is not accepted when I configure LibreTranslate as "Automatic Suggestion" provider.
For example, using Docker-compose I have the following hostname: http://libretranslate-libretranslate-1:5000
Sadly, Weblate is too strict about URL and considers that previous URL is not valid, I get the message Enter a valid URL..
Describe the solution you would like
It would be nice to be more flexible about URLs and accept container names as valid URL.
As far I can see some effort has already by done to add compatibility with Dockerized environments, for example there is WeblateServiceURLValidator.
weblate/weblate/utils/validators.py
Lines 325 to 330 in a855fe6
So it would be nice to extend this "compatibility" to "Automatic Suggestions".
Describe alternatives you have considered
No response
Screenshots
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: