Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect to many curly brackets (Python) #12197

Closed
buhtz opened this issue Aug 5, 2024 · 2 comments · Fixed by #12198
Closed

Detect to many curly brackets (Python) #12197

buhtz opened this issue Aug 5, 2024 · 2 comments · Fixed by #12198
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature.
Milestone
5.7

Comments

@buhtz
Copy link

buhtz commented Aug 5, 2024

Describe the problem

Translated strings used in Python do have (sometimes) to many curly brackets. Weblate do not warn about that. It cause Exceptions in the running code.

Describe the solution you would like

Weblate could detect it somehow.

Describe alternatives you have considered

No response

Screenshots

image

Additional context

No response
@nijel nijel self-assigned this Aug 5, 2024
@nijel nijel added the enhancement Adding or requesting a new feature. label Aug 5, 2024
@nijel nijel added this to the 5.7 milestone Aug 5, 2024
nijel added a commit to nijel/weblate that referenced this issue Aug 5, 2024
@nijel
feat(checks): detect extra curly braces in Python brace format
941373b 
Fixes WeblateOrg#12197
@nijel nijel mentioned this issue Aug 5, 2024
Merged
5 tasks
@nijel nijel closed this as completed in c006da8 Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

nijel added a commit to nijel/weblate that referenced this issue Aug 5, 2024
@nijel
fix(checks): make python brace format more robust
cf5e8d6 
- look for escaped braces in the original string as well
- treat { } escapes same as with %
- remove bogus detection of % placeable
- detect any stray { } besides parsed format string

See WeblateOrg#12198 and WeblateOrg#12197
@nijel nijel mentioned this issue Aug 5, 2024
Merged
5 tasks
nijel added a commit that referenced this issue Aug 5, 2024
@nijel
fix(checks): make python brace format more robust
eca4b37 
- look for escaped braces in the original string as well
- treat { } escapes same as with %
- remove bogus detection of % placeable
- detect any stray { } besides parsed format string

See #12198 and #12197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
5.7
Development

Successfully merging a pull request may close this issue.

feat(checks): detect extra curly braces in Python brace format nijel/weblate
2 participants
@nijel @buhtz