using @nobles/hashes (with rebase) #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #174 +/- ##
===============================================
+ Coverage 81.36% 81.42% +0.06%
===============================================
Files 46 46
Lines 4149 4141 -8
Branches 1030 1030
===============================================
- Hits 3376 3372 -4
+ Misses 741 737 -4
Partials 32 32 ☔ View full report in Codecov by Sentry. |
Closed
AlexAndrei98
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
@lenkan Thank you for the rebase! I thought i had fixed mine. 🙏🏽
|
@pfeairheller @rodolfomiranda Is this OK to merge? It works for our environment. Yesterday you mentioned that some people might have opinions on blake3 dependency, I don't recall the reasoning. |
kentbull
reviewed
Dec 9, 2023
| @@ -1,13 +1,5 @@ | |||
| import _sodium from 'libsodium-wrappers-sumo'; | |||
|
|
|||
| export const ready: () => Promise<void> = async () => { | |||
| try { | |||
|
I really hope this works. I'll be testing it out today. I assume it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the rebase and squash of #162 because we are keen to get rid of the wasm dependency of blake3.
@AlexAndrei98 you are still the author of the commit as you can see.
I will use my fork for now. It does not matter for me which PR is merged.