Integration test setup #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #152 +/- ##
============================================
Coverage 81.01% 81.01%
============================================
Files 46 46
Lines 4187 4187
Branches 1028 1028
============================================
Hits 3392 3392
Misses 763 763
Partials 32 32 ☔ View full report in Codecov by Sentry. |
pfeairheller
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lenkan @rodolfomiranda
This is a suggestion of a pattern how to setup integration tests
There are three helper methods
getOrCreateClients,getOrCreateIdentifierandgetOrCreateContactto take care of the initial setting up of Signify clients, Keri identifiers and Oobi resolution before running actual integration tests.I implemented two complete integration tests as examples: singlesig-ixn.test.ts and singlesig-rot.test.ts
getOrCreateClientsallows creating Signify clients with a random or pre-defined secret. The environment variableSIGNIFY_SECRETSallows passing pre-defined secrets from the command line.