Update S51youtubeUnblock #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entware style changes
|
Thank you! |
Waujito
requested changes
Jan 3, 2025
| @@ -1,17 +1,15 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # Pass your args here | |||
| ARGS="" | |||
| ARGS="--daemonize" | |||
There was a problem hiding this comment.
It is better to write --daemonize near the process
| $PROCS $ARGS >/dev/null 2>&1 & | ||
|
|
||
| # $PROCS $ARGS >/dev/null 2>&1 & | ||
| . /opt/etc/init.d/rc.func start $CALLER |
There was a problem hiding this comment.
I don't believe in this rc.func abstraction. I want to control everything here, inside the script. https://github.com/Entware/rtndev/blob/master/entware-opt/files/rc.func
So, keep the old runner but with --daemonize. Like $PROCS $ARGS --daemonize. Also with daemonize you don't have to /dev/null early output.
| firewall_start_v4 | ||
| firewall_start_v6 | ||
| system_config | ||
|
|
||
| echo -e "$ansi_white Started $PROCS $ansi_std" | ||
| # echo -e "$ansi_white Started $PROCS $ansi_std" |
There was a problem hiding this comment.
Without rc.func this logger is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entware style changes