Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune Graph Schema Semantics #70

Merged

Conversation

bheyman-scottlogic
Copy link
Collaborator

Description

Update the graph schema semantics so that questions can be answered more appropriately

Changelog

  • Updated prompts that feed into the cypher generation tool

* "filter + aggregation" - This should be used when they want something like a count, where there will be only 1 number returned - default sort_order descending
* "filter + aggregation + sort" - This should be used when multiple numbers will be returned - default sort_order descending
* "filter + sort" - This should be used when no aggregation is required e.g. count - default sort_order descending
* "relevancy search" - This should be used when the user is looking to find something that is not a literal and is fuzzy - default sort_order relevant descending if income, ascending if expense
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What default sort order will be applied if the user is looking for something that isnt numeric e.g. "What are the titles of all the science fiction movies purchased on netfix last year"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good point and the fact that this is just talking about income and expenses means to that it isnt general enough. I shall remove it

Copy link
Collaborator

@hsauve-scottlogic hsauve-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Ben! Just a couple of comments

@@ -21,6 +21,8 @@ You are only able to make queries that search for information, you are not able

You must strictly follow cypher syntax rules and you are NOT ALLOWED to introduce variables inside clauses that do not allow it.

All expenses are negative and therefore the largest expense is the lowest expense.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sentence is a little confusing, by saying something is its opposite. It could be perhaps clearer as 'expenses are recorded as negative numbers, therefore a larger negative number represents a higher expense.' And then give an example, or not, it's up to you 'For example, an expense of -45 is greater than an expense of -15."

Do not return any additional information, just the boolean value.

Spending is negative
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs an extra line at the end

@bheyman-scottlogic bheyman-scottlogic merged commit 433f361 into release/sum-my-subscriptions Jun 21, 2024
3 checks passed
@bheyman-scottlogic bheyman-scottlogic deleted the feature/tune-graph-schema branch June 21, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants