-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create intent agent to determine intent of question #62
create intent agent to determine intent of question #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Harry! Just a few tiny comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff Harry, just a few little minor thing I have mentioned and to gain further clarity on! Got it working on my local and does a pretty good job!
"Parameter", | ||
"tool", | ||
"validator_agent", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the datastore and maths agent be here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think they should. We're exposing agents
here which is the list of the maths and datastore agent. We should then only be accessing these agents via the agents
list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok makes sense, I wonder then if we need to differentiate between "agents" that are being used for tasks and ones that are always going to be a part of the flow ie validator. Are they still agents? The age old debate!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah a good question. I think they are still agents but like you say I think the name of the variable agents
should be changed
Description
This PR introduces an intent agent to better breakdown a user's question. It does not wire it up to the supervisor or router, that will come in a future PR
Changelog
intent_agent.py
intent-format
jinga template to define the response shape for the agentintent
jinga template to break down the user's utterance into intent and questions