False positive in AdGuard DNS list app.adjust.com

[Recoil9499]

Adguard adds app.adjust.com to their exclusion list:

AdguardTeam/AdGuardSDNSFilter#1592

But app.adjust.com still appears in:

https://v.firebog.net/hosts/AdguardDNS.txt

This causes problems with services that use that domain such as Yelp

[Recoil9499]

Thoughts @WaLLy3K ?

[KnightmareVIIVIIXC]

You need to reach out to @AdguardTeam. In the Adguard DNS Filter, there are the following rules:

!
! Title: AdGuard DNS filter
! Description: Filter composed of several other filters (AdGuard Base filter, Social media filter, Tracking Protection filter, Mobile ads filter, EasyList, EasyPrivacy, etc) and simplified specifically to be better compatible with DNS-level ad blocking.
! Homepage: https://github.com/AdguardTeam/AdguardSDNSFilter
! License: https://github.com/AdguardTeam/AdguardSDNSFilter/blob/master/LICENSE
! Last modified: 2025-02-04T12:01:36.355Z
!
! Compiled by @adguard/hostlist-compiler v1.0.29
...
||app.adjust.com^
...
! https://github.com/AdguardTeam/AdGuardSDNSFilter/issues/185
@@||app.adjust.com^|

Because of that first rule, it is being added to the Firebog mirror. It seems like @@||app.adjust.com^| was added in response to an issue, but the block rule was never removed.

[Recoil9499]

Good catch, thanks @KnightmareVIIVIIXC ! I've created an issue in their repo:

AdguardTeam/AdGuardSDNSFilter#1832

let's hope they fix it 🙏

[WaLLy3K]

Hey guys, Not quite - I need to check my parsing logic first before I'd recommend reaching out to them. I might be making a mistake on my side since it's an Adblock list, and I'm essentially just trying to fudge it into a HOSTS list. I just haven't had the time to look over this yet! 🙂

…

On Wed, Feb 5, 2025 at 5:45 am, Recoil9499 ***@***.***(mailto:On Wed, Feb 5, 2025 at 5:45 am, Recoil9499 <<a href=)> wrote: Good catch, thanks ***@***.***(https://github.com/KnightmareVIIVIIXC) ! I've created and issue in their repo, let's hope they fix it 🙏 — Reply to this email directly, [view it on GitHub](#220 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAXINNVFTHHYSFFPV3S3EAL2OEDFHAVCNFSM6AAAAABWBVKFMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZUG44DKMRXGM). You are receiving this because you were mentioned.Message ID: ***@***.***>

[KnightmareVIIVIIXC]

Hey guys,

Not quite - I need to check my parsing logic first before I'd recommend reaching out to them. I might be making a mistake on my side since it's an Adblock list, and I'm essentially just trying to fudge it into a HOSTS list.

I just haven't had the time to look over this yet! 🙂
…

No, it's not an issue on your end. It seems like your logic is fine the way it is because it just seems to exclude the @@ lines, lines with *, regex lines, and it just removes the || at the beginning and the ^ at the end of the lines that it keeps. It is an issue to have both of these rules in the list regardless because one blocks the domain and all subdomains, and the other allows domains and all of the subdomains. If you want to check your logic, that's fine, but the issue still needs to be addressed as this can cause conflict.

EDIT: Just look at the conflict it's causing here lol.

[WaLLy3K]

It's actually something I fixed long ago back in Issue #4, as @@||domain.com^ styled exceptions are supposed to be accounted for and removed.

However after breaking down my code this evening, I realised I must have made a mistake when I ported my code over and the adblock exceptions weren't being removed because of what boiled down to mere Windows carriage returns / line breaks (\r was causing exceptions to not be matched).

Normally I'm all for people going straight to the list maintainer to get their domains removed, since I'm not responsible for that. Adblock is a funny exception, because I am making large changes to make something that's not supposed to be a DNS blocklist be digestible as a HOSTS format. It's also why I have this disclaimer at the top of my Adblock converted lists:

# AdguardDNS, parsed and mirrored by https://firebog.net
# Updated [DATE] from [UPSTREAM SOURCE]

# This is sourced from an "adblock" style list which is flat-out NOT designed to work with DNS sinkholes
# There WILL be mistakes with how this is parsed, due to how domain names are extracted and exceptions handled
# Please bring any parsing issues up at https://github.com/WaLLy3K/wally3k.github.io/issues prior to raising a request upstream

# If your issue IS STILL PRESENT when using uBlock/ABP/etc, you should request a correction at [UPSTREAM REPO]

This is because I don't want people to be potentially pestering Adblock-style list maintainers for something that's potentially my own fault. This causes the person who reported the issue to get a reply saying something to the tune of "🙄 Our filter list isn't supported in the way you're using it, stop doing that".

app.adjust.com is now being removed from https://v.firebog.net/hosts/AdguardDNS.txt, and I have also regenerated all other adblock formatted lists with the latest fix. Thank you @Recoil9499, I really appreciate you bringing this to my attention! 🙂

[Recoil9499]

Thank you @WaLLy3K 💕