Upgrade to Node 20 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cable. Upgrades react-scripts to support newer TLS used by Node. Removes unnecessary polyfills no longer included by the new version of react-scripts > webpack.
rgov
reviewed
Feb 13, 2025
| @@ -26,7 +25,7 @@ export default class ImagePreviewModal extends React.Component { | |||
| <Modal size="lg" show={this.state.show} onHide={this.handleClose}> | |||
| <Modal.Header closeButton> | |||
| <Modal.Title as="h5"> | |||
| Image Preview - {Path.basename(this.props.url)} | |||
| Image Preview - {this.props.url.split('/').pop()} | |||
There was a problem hiding this comment.
I think Path.basename() conveys the concept more clearly but I am assuming it's not available for some reason?
I'm not against this just simple solution, but just noting that there might be /s in a URL that are not part of the path. E.g., http://example.com/blah?query=slashy/slashy#slash/slash
There was a problem hiding this comment.
Correct - older versions of webpack included polyfills for backend modules like Path, so it likely compiled to something like this. Upgrading to Node 20 excludes that polyfill unelss I explicitly configure it, but I am also trying to lighten the dependency tree and this seemed like a trivial need.
rgov
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.