Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more discrete roles for cruise/lowering/event access #71

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

figuernd
Copy link
Contributor

@figuernd figuernd commented Aug 29, 2024

Completes SL-44 (Jira).

Users without event access will no longer be able to replay events.

image

@figuernd figuernd requested a review from rgov August 29, 2024 19:19
@rgov
Copy link
Member

rgov commented Aug 29, 2024

Does event_manager get permission to edit events? It says "review", maybe we should reword it.

@figuernd
Copy link
Contributor Author

Does event_manager get permission to edit events? It says "review", maybe we should reword it.

AFAIK the descriptions aren't actually shown anywhere. I'll add an item to the backlog.

@webbpinner
Copy link
Contributor

On the vanilla version the descriptions appear as a tooltip when you mouse over the role checkboxes on the update_user page. It doesn't appear that part of the code has been changed within the WHOI version.

@figuernd figuernd merged commit 27b605a into main Sep 20, 2024
1 of 2 checks passed
@figuernd figuernd deleted the nathan.figueroa/SL-44 branch September 20, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants