AA storm feature / revisit landfall popup display #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-last-analysed-date-tooltip
… ssh://github.com/WFP-VAM/prism-app into feature/permanently-show-last-analysed-date-tooltip
…to aa-strom-feature/revisit-landfall-popup-display
Max-Z80
force-pushed
the
aa-storm-feature/revisit-landfall-popup-display
branch
from
9199a46 to
1635a2c
Compare
|
Build succeeded and deployed at https://prism-1410.surge.sh |
Base automatically changed from
improve-style-of-windpoint-tooltip
to
feature/add-new-AA-storm
January 14, 2025 21:03
ericboucher
changed the base branch from
feature/add-new-AA-storm
to
feature/permanently-show-last-analysed-date-tooltip
|
@Max-Z80 let's move the tooltip to the right a bit as Marc did in the Figma designs to avoid hiding parts of the country |
Base automatically changed from
feature/permanently-show-last-analysed-date-tooltip
to
feature/add-new-AA-storm
January 15, 2025 14:39
ericboucher
approved these changes
Jan 15, 2025
ericboucher
reviewed
Jan 15, 2025
| @@ -227,7 +229,7 @@ const AnticipatoryActionStormLayer = React.memo( | |||
| e.preventDefault(); | |||
| dispatch(hidePopup()); // hides the black tooltip containing the district names | |||
| const feature = e.features?.[0]; | |||
| setSelectedFeature(feature as Feature<Point>); | |||
| setSelectedFeature(feature as unknown as AAStormTimeSeriesFeature); | |||
There was a problem hiding this comment.
yes, I have pushed a simple version without unknown.
added 4 commits
January 16, 2025 12:27
…://github.com/WFP-VAM/prism-app into aa-storm-feature/revisit-landfall-popup-display
ericboucher
approved these changes
Jan 17, 2025
ericboucher
deleted the
aa-storm-feature/revisit-landfall-popup-display
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on #1407
But this PR also uses code merged from #1408 => this PR shoud be merged after #1408 is merged
LF-{date}as long as the landfall did not occur. Not visible otherwise.How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: