Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT deprecate @time-picker-open & @time-picker-close (overlay-toggle Is not a substitute) #1093

Open
alexchexes opened this issue Mar 9, 2025 · 0 comments
Labels
awaiting triage The issue is not reviewed by the maintainers enhancement New feature or request

Comments

@alexchexes
Copy link

alexchexes commented Mar 9, 2025

I just wanted to point out that, despite the docs say that we should use @overlay-toggle instead of @time-picker-open and @time-picker-close, @overlay-toggle does not provide a way to determine whether we have completely exited time-picker mode (returning to the date-picker) or if we are still in time-picker mode but have only closed the hours/minutes overlay.

I mean, the @overlay-toggle callback reports the same data:
{ overlay: 'hours', open: false }
in both scenarios:

  1. When we close the time-picker completely while in the hour-overlay.
  2. When we simply close the hour overlay while still in time-picker mode.

In contrast, @time-picker-close is only triggered when we fully close the time-picker overlay, regardless of whether we were in the hours or minutes overlay.

@alexchexes alexchexes added awaiting triage The issue is not reviewed by the maintainers enhancement New feature or request labels Mar 9, 2025
@alexchexes alexchexes changed the title DO NOT Deprecate @time-picker-open & @time-picker-close (Overlay-Toggle Is Not a Substitute) DO NOT deprecate @time-picker-open & @time-picker-close (overlay-toggle Is not a substitute) Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage The issue is not reviewed by the maintainers enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant