Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages for Code Editor #569

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Update packages for Code Editor #569

merged 6 commits into from
Dec 23, 2024

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Dec 10, 2024 •
edited
Loading

Await: PR
Resolves: #568

@vitPinchuk vitPinchuk self-assigned this Dec 10, 2024
@vitPinchuk vitPinchuk marked this pull request as draft December 10, 2024 13:05
@vitPinchuk vitPinchuk marked this pull request as ready for review December 12, 2024 13:07
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (c509597) to head (59026d2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files         116      116           
  Lines        2049     2049           
  Branches      507      533   +26     
=======================================
  Hits         2030     2030           
  Misses         17       17           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

asimonok
asimonok approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl added the enhancement New feature or request label Dec 16, 2024
@mikhail-vl mikhail-vl added this to the Forms 5.0.0 milestone Dec 16, 2024
mikhail-vl
mikhail-vl requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add E2E test

@mikhail-vl mikhail-vl requested a review from asimonok December 18, 2024 11:12
@vitPinchuk
Copy link
Contributor Author

@asimonok @mikhail-vl ready for review

asimonok
asimonok approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 7fbfabf into main Dec 23, 2024
8 checks passed
@mikhail-vl mikhail-vl deleted the feat/upd-packages-for-components branch December 23, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimonok asimonok asimonok approved these changes

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Forms 5.0.0
Development

Successfully merging this pull request may close these issues.

Incorrect escaping of values in code editors for execution
3 participants
@vitPinchuk @asimonok @mikhail-vl