Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default payload from Update Request #550

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Remove default payload from Update Request #550

merged 3 commits into from
Nov 15, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #546

@vitPinchuk vitPinchuk self-assigned this Nov 14, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.19%. Comparing base (9c1ff1b) to head (e8ee28f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files         115      115           
  Lines        1986     1986           
  Branches      519      519           
=======================================
  Hits         1970     1970           
  Misses         14       14           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

asimonok
asimonok approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 15, 2024
@mikhail-vl mikhail-vl added this to the Forms 4.9.0 milestone Nov 15, 2024
mikhail-vl
mikhail-vl approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit f9cd9e8 into main Nov 15, 2024
4 of 6 checks passed
@mikhail-vl mikhail-vl deleted the feat/update-payload-default branch November 15, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimonok asimonok asimonok approved these changes

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Forms 4.9.0
Development

Successfully merging this pull request may close these issues.

Remove default payload from Update Request
3 participants
@vitPinchuk @asimonok @mikhail-vl