Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable columns in confirmation modal #360

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Mar 1, 2024

Resolves #342

Include columns option
Screenshot 2024-03-01 at 09 14 09

@asimonok asimonok requested a review from mikhail-vl March 1, 2024 06:15
@asimonok asimonok self-assigned this Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 97.47%. Comparing base (29425ae) to head (fa99001).

Files Patch % Lines
src/components/FormPanel/FormPanel.tsx 66.66% 4 Missing and 1 partial ⚠️
src/module.ts 0.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   98.04%   97.47%   -0.57%     
==========================================
  Files          69       71       +2     
  Lines        1175     1189      +14     
  Branches      214      224      +10     
==========================================
+ Hits         1152     1159       +7     
- Misses         13       17       +4     
- Partials       10       13       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Mar 8, 2024
@mikhail-vl mikhail-vl added this to the Version 3.7.0 milestone Mar 8, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 2708912 into main Mar 8, 2024
4 of 6 checks passed
@mikhail-vl mikhail-vl deleted the feat/confirm-modal-columns-visibility branch March 8, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More flexible confirmation Window settings
2 participants