Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code parameters with builder and add initial request to element value changed code #358

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Feb 29, 2024

Resolves #333
Resolves #346

@asimonok asimonok self-assigned this Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (ee518cf) to head (f5c15aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   98.03%   98.04%   +0.01%     
==========================================
  Files          68       69       +1     
  Lines        1168     1175       +7     
  Branches      214      214              
==========================================
+ Hits         1145     1152       +7     
  Misses         13       13              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asimonok asimonok changed the title Create code parameters with builder Create code parameters with builder and add initial request to element value changed code Feb 29, 2024
@asimonok asimonok requested a review from mikhail-vl February 29, 2024 11:56
@mikhail-vl mikhail-vl added the enhancement New feature or request label Mar 8, 2024
@mikhail-vl mikhail-vl added this to the Version 3.7.0 milestone Mar 8, 2024
@mikhail-vl mikhail-vl changed the title Create code parameters with builder and add initial request to element value changed code Add code parameters with builder and add initial request to element value changed code Mar 8, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 29425ae into main Mar 8, 2024
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/context-parameters-builder branch March 8, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling initialRequest() Within Form Events Create custom code context parameters builder
2 participants