Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset button confirmation #328

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Add reset button confirmation #328

merged 4 commits into from
Jan 4, 2024

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Jan 4, 2024

No description provided.

@asimonok asimonok requested a review from mikhail-vl January 4, 2024 06:51
@asimonok asimonok self-assigned this Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5fe915e) 98.05% compared to head (1e3280e) 97.98%.

Files Patch % Lines
src/components/FormPanel/FormPanel.tsx 66.66% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   98.05%   97.98%   -0.08%     
==========================================
  Files          66       66              
  Lines        1132     1140       +8     
  Branches      208      210       +2     
==========================================
+ Hits         1110     1117       +7     
- Misses         12       13       +1     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jan 4, 2024
@mikhail-vl mikhail-vl added this to the Version 3.5.0 milestone Jan 4, 2024
@mikhail-vl mikhail-vl changed the title Add reset values confirmation Add reset button confirmation Jan 4, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit c26e2ee into main Jan 4, 2024
4 of 6 checks passed
@mikhail-vl mikhail-vl deleted the feat/reset-confirmation branch January 4, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants