Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reset request visibility if reset button is hidden #322

Merged
merged 4 commits into from
Jan 1, 2024

Conversation

asimonok
Copy link
Collaborator

Resolves #303

@asimonok asimonok requested a review from mikhail-vl December 29, 2023 09:01
@asimonok asimonok self-assigned this Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88bceb3) 97.96% compared to head (549bd02) 97.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          66       66           
  Lines        1082     1082           
  Branches      195      198    +3     
=======================================
  Hits         1060     1060           
  Misses         12       12           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added this to the Version 3.5.0 milestone Jan 1, 2024
@mikhail-vl mikhail-vl changed the title Hide reset request if reset button is hidden Update reset request visibility if reset button is hidden Jan 1, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 06bd1fe into main Jan 1, 2024
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/hide-reset-request-if-disabled branch January 1, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Reset request and other options when hide Reset button
2 participants