Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataProcessPlots): Remove duplicate log-transformation of intensity #98

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Sep 13, 2024

Motivation and Context

In this google group post, the user pointed out that medians were not equalized in the QC plot. After investigating, it looks to be a bug in the dataProcessPlots function.

Changes

  • Remove code that log transforms the intensity into the abundance column in dataProcessPlots. This code essentially log transforms the data and removes all normalization applied earlier.

Testing

  • Generated new plots with summary.data object and medians are equalized now.
  • Added unit test that verified abundance data was not manipulated - i.e. medians are all equal

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@tonywu1999 tonywu1999 merged commit 4111c18 into devel Sep 24, 2024
1 check passed
@tonywu1999 tonywu1999 deleted the test-bug-fix branch September 24, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant