Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linear-summarization): Fix segfault bug in get_linear_summary #148

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Jan 7, 2025

This dry run build is failing due to a segfault that is only caught in the CI/CD workflow. It seems that the issue is the use of single & instead of double && to perform boolean IF statement checks. See this post on the differences and why it matters.

Just remember that if you encounter a problem in life, even a segfault, you can do anything. You can even fly.

Copy link

github-actions bot commented Jan 7, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link

github-actions bot commented Jan 7, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@tonywu1999 tonywu1999 changed the title testing CI workflow CI workflow test Jan 7, 2025
@tonywu1999
Copy link
Contributor Author

Debugging process:

  1. Pushed a dummy commit to verify that it was a problem on the devel branch as well.
  2. Thought it had to do with the ubuntu migration based on this article and this post. Downgraded ubuntu to 22.04, but that didn't work.
  3. Turned off any vignettes / tests related to linear summarization, and bugs disappeared, indicating it was isolated to the linear summarization code.
  4. Sprinkled debug C++ print statements Rcout << "Input vector: " << x << std::endl;. Discovered line of code that was causing the issue.
  5. Identified this stackoverflow post on differences between & and &&

I still have no idea why this error started popping up today but went undetected in the past. Plus it's still passing in our local machines.

@tonywu1999 tonywu1999 changed the title CI workflow test fix(linear-summarization): Fix segfault bug in get_linear_summary Jan 8, 2025
@tonywu1999 tonywu1999 merged commit a1760a1 into devel Jan 9, 2025
1 check passed
@tonywu1999 tonywu1999 deleted the test branch January 9, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant