Skip to content

Fix incorrect ppmm inlining #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 22, 2025
Merged

Fix incorrect ppmm inlining #451

merged 5 commits into from
Feb 22, 2025

Conversation

Kroppeb
Copy link
Contributor

@Kroppeb Kroppeb commented Jan 10, 2025

Fixes that foo(++a, a) gets decompiled to foo(a, ++a) and all other related issues.

@Kroppeb Kroppeb added the bugfix Fixes a bug label Jan 10, 2025
@Kroppeb Kroppeb requested a review from jaskarth January 10, 2025 19:19
@Kroppeb Kroppeb self-assigned this Jan 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

Test Results

   18 files  ±0     18 suites  ±0   1m 4s ⏱️ -1s
1 937 tests ±0  1 937 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 570 runs  ±0  2 570 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 42d672b. ± Comparison against base commit 317e74b.

♻️ This comment has been updated with latest results.

jaskarth
jaskarth approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@jaskarth jaskarth added Subsystem: Statement Structure Anything concerning how statements are structured in a method Priority: Medium Medium priority labels Feb 22, 2025
@jaskarth jaskarth merged commit 8f65bd9 into develop/1.11.0 Feb 22, 2025
9 checks passed
jaskarth pushed a commit that referenced this pull request Feb 24, 2025
@Kroppeb @jaskarth
Fix incorrect ppmm inlining (#451)
43aaa89 
* Add bad test for ppmm inlining

* Update test

* Fix ppmm bug

* More bad case :(

* Fix array assign ppmm bug
jaskarth pushed a commit that referenced this pull request Feb 25, 2025
@Kroppeb
Fix incorrect ppmm inlining (#451)
38dbf1a 
* Add bad test for ppmm inlining

* Update test

* Fix ppmm bug

* More bad case :(

* Fix array assign ppmm bug
jaskarth pushed a commit that referenced this pull request Feb 25, 2025
@Kroppeb @jaskarth
Fix incorrect ppmm inlining (#451)
a6698b7 
* Add bad test for ppmm inlining

* Update test

* Fix ppmm bug

* More bad case :(

* Fix array assign ppmm bug
jaskarth pushed a commit that referenced this pull request Feb 25, 2025
@Kroppeb
Fix incorrect ppmm inlining (#451)
0be304f 
* Add bad test for ppmm inlining

* Update test

* Fix ppmm bug

* More bad case :(

* Fix array assign ppmm bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskarth jaskarth jaskarth approved these changes

Assignees

@Kroppeb Kroppeb

Labels
bugfix Fixes a bug Priority: Medium Medium priority Subsystem: Statement Structure Anything concerning how statements are structured in a method
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kroppeb @jaskarth