test: Remove orphaned snapshots #64
Conversation
|
Proof of it working on these 2 commits: |
| let mut orphans = false; | ||
| for entry in entries { | ||
| let Ok(entry) = entry else { | ||
| continue; |
There was a problem hiding this comment.
if you remove the semicolon here (and on the other continues), rustfmt should collapse these to a single line, which I think looks a bit nicer
|
|
||
| let file_name = file_name_str.to_owned(); | ||
| if !names.contains(&file_name) { | ||
| orphans = true; |
There was a problem hiding this comment.
When there are orphaned snapshots, instead of always deleting the files and always failing, can you branch on should_write_snapshot() and either delete the snapshots and succeed, or fail and leave the snapshots be?
| remove_orphan_snapshots("tests/snaps/vine", &vine_tests); | ||
| }); | ||
| t.test("vine_fail", move || { | ||
| remove_orphan_snapshots("tests/snaps/vine_fail", &vine_fail_tests); |
There was a problem hiding this comment.
can you change this to fail/vine? should make tab completing nicer
|
It's not very robust atm, so I'm thinking if there's a nice way to do it without pulling in a dependency like https://docs.rs/ignore/latest/ignore/ |
|
IMO it's fine for it to depend on the non-existence of other things in those directories |
This PR will now make any invocation of
cargo testremove any snapshots with no corresponding test file.We have moved the
vine/failtests to its own foldervine_failCloses #49