vine: ast validation #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Open
vjjft
approved these changes
Oct 6, 2024
tjjfvi
force-pushed
the
error-reporting
branch
from
fb302ab to
7acff85
Compare
tjjfvi
force-pushed
the
error-reporting
branch
from
7acff85 to
04d751b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ast validation pass, between name resolution and desugaring. Currently, it checks that expressions and pattern have the proper form (value/place/expr) and that non-match patterns are irrefutable.
The
Termnode in the AST has been split intoExprandPat; having them combined was saving a little bit of parser code, but was ultimately making the rest of the code more complicated.The AST now makes form coercions explicit (these are inserted in the validation pass), which simplifies the compiler code a bit.
_is now just a space expression;()can be used instead to create a nilary value. (Or, I suppose,~_.)