Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ViaMCP for MCP Reborn #31

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

NickReset
Copy link

it's crazy that ViaMCP still does not have support for MCP Reborn

Copy link
Member

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People just shouldn't use MCP in modern versions as proper mod loading systems like Fabric or NeoForge exists. Making a MCP based mod usually means not updating to newer versions since you don't know which modifications you made to the codebase and also you aren't able to install mods like Sodium/ImmediatelyFast which are quite important for proper gameplay in terms of performance (at least in my opinion).

I'll review/merge your changes later, maybe we could also add 1.16.5 since many people asked for this? Also what 1.20 is this? The folder should have the exact name.

@NickReset
Copy link
Author

1.20.2 is the version I'll change that for you

@FlorianMichael
Copy link
Member

1.20.2 is random, it should be either 1.20.6 or 1.21

@ghywk
Copy link

ghywk commented Aug 15, 2024

Adding version 1.18.1 may be good?
idk

@FlorianMichael
Copy link
Member

1.18.1 is even more random imo, 1.18.2 can be done if people want it but I generally don't recommend MCP for modern versions (and also not versions below 1.20.4)

@DataM0del
Copy link

it's crazy that ViaMCP still does not have support for MCP Reborn

It's crazy that people still use MCP instead of Fabric. It's also crazy that there are people who call Yarn "ass" (it's not) meanwhile Searge having 5000 useful functions not mapped, and Yarn has most of them remapped.
I can't wait for MCP & Searge to die.

  • You can't stack mods with MCP without hacks like Reflection, and even then, it's really annoying to have to tell everyone "depend on my mod in your mod manifest file, Mixins will do their thing, and you can fix conflicts & compatibility issues if present", but then realize that some idiot is still using MCP instead of mod loaders
  • Issues that are caused by your modifications to Minecraft's code, if you don't know where to look. Imagine you want to spoof the yaw & pitch being sent to the server, you create an event, and in the entity code where the packet is sent, you modify the code to use yours. Oops! You forgot to modify this other thing, and now it's all falling down. Oops! You changed other entities that aren't your player's yaw, now everyone is looking backwards from your view.
  • Licensing issues. Now you want to distribute your client. You distributed it, oops! Looks like you broke Mojang's EULA! It says "Do not distribute" in the corner, that means it's probably in their EULA, and you just distributed Minecraft with some modifications, I could confuse the 500 other Minecraft classes you didn't change enough and say that's a copyright violation. Whereas with mods, you aren't distributing Minecraft, you're distributing pretty much a patch / diff for your modifications to Minecraft, these are called Mixins, and Fabric or your mod loader will change Minecraft's bytecode around so you can make your modifications without breaking their EULA and getting told no as soon as you get any attention enough to get someone at Mojang to look at your client and see it's basically their source.

@melodeu
Copy link

melodeu commented Jan 27, 2025

it's crazy that ViaMCP still does not have support for MCP Reborn

It's crazy that people still use MCP instead of Fabric. It's also crazy that there are people who call Yarn "ass" (it's not) meanwhile Searge having 5000 useful functions not mapped, and Yarn has most of them remapped.
I can't wait for MCP & Searge to die.

  • You can't stack mods with MCP without hacks like Reflection, and even then, it's really annoying to have to tell everyone "depend on my mod in your mod manifest file, Mixins will do their thing, and you can fix conflicts & compatibility issues if present", but then realize that some idiot is still using MCP instead of mod loaders
  • Issues that are caused by your modifications to Minecraft's code, if you don't know where to look. Imagine you want to spoof the yaw & pitch being sent to the server, you create an event, and in the entity code where the packet is sent, you modify the code to use yours. Oops! You forgot to modify this other thing, and now it's all falling down. Oops! You changed other entities that aren't your player's yaw, now everyone is looking backwards from your view.
  • Licensing issues. Now you want to distribute your client. You distributed it, oops! Looks like you broke Mojang's EULA! It says "Do not distribute" in the corner, that means it's probably in their EULA, and you just distributed Minecraft with some modifications, I could confuse the 500 other Minecraft classes you didn't change enough and say that's a copyright violation. Whereas with mods, you aren't distributing Minecraft, you're distributing pretty much a patch / diff for your modifications to Minecraft, these are called Mixins, and Fabric or your mod loader will change Minecraft's bytecode around so you can make your modifications without breaking their EULA and getting told no as soon as you get any attention enough to get someone at Mojang to look at your client and see it's basically their source.

holy yap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants