-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci(PullRequestWorkflows): correct event to base changes (#27)
### Correction on where to base the context when running actions ### Contribution Type - [ ] Issue (Feature) - [x] Issue (Bug Fix) - [ ] Security Update ### Design Decisions `pull_request_target` runs the workflow while based on the base branch - for unit testing, this doesn't test the code that the user plans to merge - rather the code that is already in the `main` branch. Using `pull_request` event will correctly run the unit tests against what the user is submitting in the pull_request. ### Testing N/A
- Loading branch information
1 parent
bceec00
commit b763d6f
Showing
6 changed files
with
6 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
name: Lint CloudFormation Templates | ||
|
||
on: | ||
pull_request_target: | ||
pull_request: | ||
|
||
|
||
jobs: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
name: Python Lint | ||
on: | ||
pull_request_target: | ||
pull_request: | ||
|
||
jobs: | ||
lint-python: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,7 @@ | |
name: AWS States Lint | ||
|
||
on: | ||
fork: | ||
pull_request_target: | ||
pull_request: | ||
|
||
jobs: | ||
lint: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
name: Yaml Lint | ||
on: | ||
pull_request_target: | ||
pull_request: | ||
|
||
jobs: | ||
lint-yaml: | ||
|