Support of the WASM build #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #474 +/- ##
==========================================
+ Coverage 73.67% 73.82% +0.14%
==========================================
Files 30 30
Lines 4251 4279 +28
Branches 968 975 +7
==========================================
+ Hits 3132 3159 +27
- Misses 771 772 +1
Partials 348 348 ☔ View full report in Codecov by Sentry. |
jurajsic
reviewed
Nov 29, 2024
| @@ -108,7 +108,7 @@ public: | |||
| } | |||
|
|
|||
| if (elem) | |||
| --elem->counter_; | |||
| --elem->refcount_; | |||
There was a problem hiding this comment.
This seems like quite random fix, how did you find this bug?
There was a problem hiding this comment.
It simply does not compile. Maybe it has something to do with the emscripten that is used for the build (but the counter_ is indeed not present there, it is a real error).
There was a problem hiding this comment.
Really weird, maybe the function is never used, so the compiler removes it? But it should still not compile normally, weird.
jurajsic
approved these changes
Nov 29, 2024
Adda0
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.