Tabakov-Vardi generator #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adda0
approved these changes
Nov 20, 2024
Adda0
reviewed
Nov 21, 2024
Co-authored-by: David Chocholatý <chocholaty.david@protonmail.com>
jurajsic
reviewed
Nov 22, 2024
jurajsic
reviewed
Nov 22, 2024
jurajsic
reviewed
Nov 22, 2024
jurajsic
reviewed
Nov 22, 2024
jurajsic
reviewed
Nov 24, 2024
jurajsic
reviewed
Nov 24, 2024
|
What is the state of this PR? Are you working in anything else, or is it considered final and ready for merging? |
It's the final version, and it is ready to be merged. |
|
@jurajsic What do you think? Anything more to improve? Are you OK with the current solution to the casting between |
jurajsic
approved these changes
Nov 25, 2024
hiraethese
pushed a commit
to hiraethese/mata
that referenced
this pull request
Dec 19, 2024
* Tabakov-Vardi generator * big test * renaming * Update include/mata/nfa/builder.hh Co-authored-by: David Chocholatý <chocholaty.david@protonmail.com> * renaming + new unique state/transition generator * fin_state_density range changed to [0;1] * paper * float -> double + off-by-one potential error fix * comment --------- Co-authored-by: David Chocholatý <chocholaty.david@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Tabakov-Vardi random automata generator and corresponding tests.