[VEN-3074] Add vip for the wstETH pool for Base and Zksync #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chechu
reviewed
Feb 20, 2025
kkirka
reviewed
Feb 24, 2025
GitGuru7
reviewed
Feb 24, 2025
chechu
reviewed
Feb 24, 2025
chechu
reviewed
Feb 24, 2025
chechu
reviewed
Feb 24, 2025
kkirka
reviewed
Feb 25, 2025
simulations/vip-454/zksyncmainnet.ts
Outdated
Comment on lines
50
to
54
| describe("vTokens deployment", () => { | ||
| it(`should deploy market`, async () => { | ||
| await checkVToken(zksyncMarket.vToken.address, zksyncMarket.vToken); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| describe("vTokens deployment", () => { | |
| it(`should deploy market`, async () => { | |
| await checkVToken(zksyncMarket.vToken.address, zksyncMarket.vToken); | |
| }); | |
| }); | |
| describe("vTokens deployment", () => { | |
| checkVToken(zksyncMarket.vToken.address, zksyncMarket.vToken); | |
| }); |
simulations/vip-454/zksyncmainnet.ts
Outdated
| ); | ||
| }); | ||
|
|
||
| describe("generic tests", async () => { |
There was a problem hiding this comment.
Suggested change
| describe("generic tests", async () => { | |
| describe("generic tests", () => { |
Comment on lines
+143
to
+145
| checkIsolatedPoolsComptrollers({ | ||
| [COMPTROLLER_CORE_ZKSYNC]: WSTETH_HOLDER, | ||
| }); |
There was a problem hiding this comment.
This won't actually check supplying or borrowing wstETH. Rather, with the current implementation of checkIsolatedPoolsComptrollers it would skip the checks (note the absence of "supplying X, borrowing Y" tests):
Might be ok to leave it as is for this VIP, though, it's seemingly out of the scope.
kkirka
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
anvil-zksync fork --fork-url sepolia-testnet --fork-block-number 4761402Resolves VEN