Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2216] [VEN-2217] [VEN-2286]: send XVS to dest chain to configure the rewards (Sepolia, Ethereum) #119

Merged
merged 24 commits into from
Mar 18, 2024

Conversation

GitGuru7
Copy link
Contributor

@GitGuru7 GitGuru7 commented Dec 6, 2023

Resolves VEN-2216 and VEN-2217

@GitGuru7 GitGuru7 requested a review from chechu December 6, 2023 09:34
@GitGuru7 GitGuru7 self-assigned this Dec 6, 2023
@chechu chechu requested a review from 0xlucian December 6, 2023 10:55
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GitGuru7
Copy link
Contributor Author

GitGuru7 commented Dec 6, 2023

@GitGuru7
Copy link
Contributor Author

GitGuru7 commented Dec 6, 2023

VIP to send XVS on destination (https://testnet.bscscan.com/tx/0xc25ac405d0e04e068e7c604fa7204b50a1571c32986ffe6ef540f98857feeba1) succeed on src chain but failed on dest chain because we did not have much minting limits so I executed this new proposal (https://sepolia.etherscan.io/tx/0x3158e69afdc03594b1d2e12026cd675a8398a040876c9e97dbe47a68321bf17a) to increase mint limits and retry the message on destination (https://sepolia.etherscan.io/tx/0x8d3cf4debee84f8f9665ea70216e7d8c3ef51e6e703544e7b431b6ec5264f942) and it worked perfectly now we are having 5000XVS on Treasury address.

@chechu chechu changed the title [VEN-2216]: send XVS to destination chain [VEN-2216]: send XVS to sepolia to configure the rewards Dec 7, 2023
@chechu
Copy link
Member

chechu commented Dec 7, 2023

I wouldn't merge this PR until we have the equivalent VIP on the BNB side for mainnet

Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testnet VIP's LGTM

@GitGuru7 GitGuru7 changed the title [VEN-2216]: send XVS to sepolia to configure the rewards [VEN-2216]: send XVS to dest chian to configure the rewards (Sepolia, Ethereum) Jan 2, 2024
@chechu chechu changed the title [VEN-2216]: send XVS to dest chian to configure the rewards (Sepolia, Ethereum) [VEN-2216]: send XVS to dest chain to configure the rewards (Sepolia, Ethereum) Jan 3, 2024
@chechu chechu changed the title [VEN-2216]: send XVS to dest chain to configure the rewards (Sepolia, Ethereum) [VEN-2216] [VEN-2217]: send XVS to dest chain to configure the rewards (Sepolia, Ethereum) Jan 8, 2024
@chechu chechu added sepolia and removed don't merge labels Jan 8, 2024
@web3rover web3rover changed the title [VEN-2216] [VEN-2217]: send XVS to dest chain to configure the rewards (Sepolia, Ethereum) [VEN-2216] [VEN-2217] [VEN-2286]: send XVS to dest chain to configure the rewards (Sepolia, Ethereum) Jan 10, 2024
@web3rover web3rover self-assigned this Jan 10, 2024
@web3rover web3rover requested review from chechu and 0xlucian January 10, 2024 11:06
@chechu
Copy link
Member

chechu commented Jan 14, 2024

@chechu
Copy link
Member

chechu commented Mar 15, 2024

@GitGuru7 GitGuru7 merged commit 92352dc into develop Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants