Feature: task time limits (and other related stuff) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next big question is this: how do we correctly and safely set up a real time limit on Unix? It seems not everyone may have |
|
While we're at it, we are also adding tests to assert the task runner is really being run silently. |
Further study required!
|
The original plan was to somehow get the basic test cases passing, then work on edge case test cases, but it turned out, the very intense bug-fixing involved one of the do-it-later edge cases... |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default task time limit is 30 seconds, just as the PHP default. Time limit can be disabled, but be careful with runaway processes.
We are talking about real time limit. Time spent on sleeping, waiting, etc will also be counted.