onboard BGE-Base-EN-v1.5 and All-MiniLM-L6-v2 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2025 00:45
…o use --task flag in vllm.
XkunW
approved these changes
Jan 31, 2025
kohankhaki
added a commit
that referenced
this pull request
Feb 1, 2025
onboard BGE-Base-EN-v1.5 and All-MiniLM-L6-v2
|
@kohankhaki, seems like model_type is no longer a default arg, and is now required?. Could you please fix the unit test test_load_default_args as well? |
|
@amrit110 Marshall has solved this in his last push to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
Short Description
Added BGE-Base-EN-v1.5 and All-MiniLM-L6-v2 models.
Added
--taskflag in the scripts.