[TF2] Fix medigun prediction errors #1215
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is kind of a dupe of #899? I'm mildly biased as the author of that PR but I don't think is a great fix since the issue isn't that it has no tolerance but rather that the client doesn't handle any charge rate modifications. Some tolerance probably would be good but its not really the issue imo. |
|
your fix doesn't work when draining uber as that will still cause pred errors |
|
ah good catch! I wasn't aware of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When healing someone with the medigun, it will cause prediction errors to constantly appear on the medigun due to m_flChargeLevel having no tolerance at all