Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Message parameter in Assert.Pass doesn't appear to be used anywhere #162

Open
rmcginty opened this issue Oct 4, 2016 · 2 comments

Comments

@rmcginty
Copy link
Contributor

rmcginty commented Oct 4, 2016

While working on a test today, I noticed the Assert.Pass method had a message param. I used it, but it doesn't appear to output in any of the loggers that I looked at (console, GUI - I didn't actually check xml). Is this used anywhere or did it falls between the cracks during implementation? I can make the changes so it outputs in relevant places, but didn't know if there was a reason or more to story as to it not outputting currently.

@vincentparrett
Copy link
Member

Looks like an oversight. The message is passed into the testresult, so it should be available in the logger. Feel free to submit a pull request. You will need to add it to each of the loggers, adding to the console is simple, adding to the others you will need to check, I suspect for the nunit one you just need to add a message node (if message is not empty).

@rmcginty
Copy link
Contributor Author

rmcginty commented Oct 5, 2016

Got it. I'll take care of it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants