Current connection indication #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature #458 +/- ##
==========================================
Coverage 92.92% 92.92%
Complexity 922 922
==========================================
Files 131 131
Lines 2726 2726
Branches 221 221
==========================================
Hits 2533 2533
Misses 58 58
Partials 135 135 |
VREMSoftwareDevelopment
requested changes
Jan 20, 2024
|
closes #456 |
mx1up
force-pushed
the
current_connection_indication
branch
from
1d16ef1 to
1fdd888
Compare
|
I rebased on upstream feature branch , trying to fix code coverage issue |
VREMSoftwareDevelopment
approved these changes
Jan 27, 2024
VREMSoftwareDevelopment
merged commit e71132f
into
VREMSoftwareDevelopment:feature
5 checks passed
|
Thanks for the contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Please describe.
puts an informative text on top of current connection tile indicating it is the current connection.
Does this close any currently open issues?
fixes #456
Additional context
I wasn't sure where to put the translation in the translation file as I did not really find a fitting section.
Where has this been tested?