Scatter correlations #258
Merged
Scatter correlations #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asizemore
reviewed
May 1, 2024
tests/testthat/test-scattergl.R
Outdated
| @@ -772,7 +772,7 @@ test_that("scattergl.dt() returns an appropriately sized data.table", { | |||
|
|
|||
| dt <- scattergl.dt(df, variables, 'raw') | |||
| expect_equal(nrow(dt), 9) | |||
| expect_equal(names(dt), c('entity.cat3', 'entity.factor3','seriesX','seriesY')) | |||
| expect_equal(names(dt), c('entity.factor3', 'entity.cat3','seriesX','seriesY', 'correlationCoef', 'pValue')) | |||
There was a problem hiding this comment.
there have been a few name swaps like this one for factor3 and cat3. Did we just have lots of tests failing for a while?
There was a problem hiding this comment.
i suspect i need to revisit github actions testing for veupathUtils and plot.data though. i feel like i def saw a veupathUtils github actions test pass the other day that i knew should fail...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in support of bpnet 2.0 scatter plots